Skip to content

Fix Scala 3 macros for Message #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

kojunho7
Copy link
Contributor

Without the delegate, it causes a recursive inline method.

@vy vy self-assigned this Dec 21, 2023
@vy vy merged commit 813ccea into apache:main Dec 21, 2023
@vy
Copy link
Member

vy commented Dec 21, 2023

@kojunho7, thanks so much for the contribution. I verified that, without the fix, tests indeed do fail due to recursive inlining.

I can make a minor release (i.e., 13.1.0) containing this fix. Is there anything else you want to contribute before the release?

@vy vy added the bug label Dec 21, 2023
@vy vy added this to the 13.0.1 milestone Dec 21, 2023
vy added a commit that referenced this pull request Dec 21, 2023
@kojunho7
Copy link
Contributor Author

All set for now, thanks!

@kojunho7
Copy link
Contributor Author

kojunho7 commented Feb 1, 2024

@vy When will 13.1.0 be released? Please release it if possible.

@ppkarwasz
Copy link
Contributor

@kojunho7,

Dotty compiler 3.3.2 (cf. this thread) and 3.4.0 (cf. this thread) are due to be released very soon.

They fix our reproducibility problems in #34. Reproducibility is important for the Release Manager, who needs to justify that the artifacts generated by the CI are not corrupted.

@vy
Copy link
Member

vy commented Feb 1, 2024

@ppkarwasz, shared Dotty compiler release schedules point to the end of January and sometime in February, nothing concrete. We released 13.0.0 with the aforementioned reproducibility caveat, I think we can do the same for 13.1.0 too.

@kojunho7, will start the release process today. I expect the release to be delivered in ~3 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants